Re: PATCH: To fix minor patches (pgAdmin4) - Mailing list pgadmin-hackers
Hi Ashesh,
It is difficult to handle in each template with various options user can choose from,
We try to handle as much as possible space indentation in templates itself but still we got some extra spaces when user selects different options,
that's why we are doing this operation outside. I did not found any other suitable solution for this issue.
Regards,
Murtuza
--
Regards,
On Fri, Jun 3, 2016 at 3:35 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
On Thu, Jun 2, 2016 at 6:11 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,PFA updated patch for RM#1234.Please do not tweak the '\n' off the output, but - fix the issue from the template itself.--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
Regards,Murtuza--Regards,On Thu, Jun 2, 2016 at 3:38 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:On Wed, Jun 1, 2016 at 1:23 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,PFA minor patches to fix RM#1234, RM#1279.I've committed the fix for RM#1276.But - Proposed fix for RM#1234 does not look right to me.Consider a name, value has ';' (semicolon) within it, the SQL will generated will be wrong.i.e. Put a semicolon in comments.--Regards,
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
pgadmin-hackers by date: