Re: PATCH: To fix minor patches (pgAdmin4) - Mailing list pgadmin-hackers

From Ashesh Vashi
Subject Re: PATCH: To fix minor patches (pgAdmin4)
Date
Msg-id CAG7mmox7zjkESFbrrd+joDfGEN+TTHKmEEQryp5FeCdLOOZ8oQ@mail.gmail.com
Whole thread Raw
In response to Re: PATCH: To fix minor patches (pgAdmin4)  (Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>)
Responses Re: PATCH: To fix minor patches (pgAdmin4)  (Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>)
List pgadmin-hackers

On Thu, Jun 2, 2016 at 6:11 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hi,

PFA updated patch for RM#1234.
Please do not tweak the '\n' off the output, but - fix the issue from the template itself.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company




Regards,
Murtuza

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Thu, Jun 2, 2016 at 3:38 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:

On Wed, Jun 1, 2016 at 1:23 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hi,

PFA minor patches to fix RM#1234, RM#1279.
I've committed the fix for RM#1276.

But - Proposed fix for RM#1234 does not look right to me.

Consider a name, value has ';' (semicolon) within it, the SQL will generated will be wrong.
i.e. Put a semicolon in comments.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi

 

 
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers




pgadmin-hackers by date:

Previous
From: Murtuza Zabuawala
Date:
Subject: PATCH: To fix issue in table node (pgAdmin4)
Next
From: Ashesh Vashi
Date:
Subject: pgAdmin 4 commit: Fixes #1285 - Update the comments (description) over