On Thu, Feb 26, 2026 at 8:55 AM Robert Haas <robertmhaas@gmail.com> wrote: > Thanks, Alex, for the review.
Here's v18. In addition to fixing the problems pointed out by Alex, there are a couple of significant changes in this version.
I have a mind to walk through the readmes and sgmls but its going to be in chunks. Here's one for the readme for pg_plan_advice with a couple of preliminary sgml changes.
0003 sgml focus with some readme.
And now 0004 sgml (no readme):
My OCD wants these named pg_advice_{plan,collect,stash} so they sort together.
Strongly thinking using "entries" throughout makes more sense than "query texts and advice string" - it is shorter and more inclusive since the actual stored info covers IDs and timestamp.
I made one swap where shared was being mentioned before local.
I added some unresearched answers to open questions I had at the end of the main section. Namely, pertaining to advice feedback output and capturing explain plans themselves.
