Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] Proposal: GetOldestXminExtend for ignoring arbitraryvacuum flags - Mailing list pgsql-hackers

From Haribabu Kommi
Subject Re: [HACKERS] Proposal: GetOldestXminExtend for ignoring arbitraryvacuum flags
Date
Msg-id CAJrrPGcsDC-oy1AhqH0JkXYa0Z2AgbuXzHPpByLoBGMxfOZMEQ@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Proposal: GetOldestXminExtend for ignoring arbitraryvacuum flags  ("Seki, Eiji" <seki.eiji@jp.fujitsu.com>)
Responses Re: [HACKERS] Proposal: GetOldestXminExtend for ignoring arbitraryvacuum flags  (Simon Riggs <simon@2ndquadrant.com>)
List pgsql-hackers
Tree view


On Wed, Mar 22, 2017 at 1:53 PM, Seki, Eiji <seki.eiji@jp.fujitsu.com> wrote:

Thank you for your review, again.

I think your proposals are better, so I reflected them.

Thanks for the updated patch. Patch looks good to me.
I marked it as "ready for committer".

While reviewing this patch, I found that PGXACT->vacuumFlags
variable name needs a rename because with the addition of
PROC_IN_LOGICAL_DECODING flag "vacuumFlags" doesn't
only use it for vacuum operation. I feel this variable can be renamed
as just "flags", but anyway that is a different patch.

Regards,
Hari Babu
Fujitsu Australia

pgsql-hackers by date:

Previous
From: Craig Ringer
Date:
Subject: Re: [HACKERS] Allow pg_dumpall to work without pg_authid
Next
From: Peter Eisentraut
Date:
Subject: Re: [HACKERS] PUBLICATIONS and pg_dump