Re: Correction in doc of failover ready steps - Mailing list pgsql-docs

From shveta malik
Subject Re: Correction in doc of failover ready steps
Date
Msg-id CAJpy0uDiaZWp_p5WEavgu0QgKxdMBT4nbCEYMYcO2sYdcDqxEg@mail.gmail.com
Whole thread Raw
In response to RE: Correction in doc of failover ready steps  ("Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>)
List pgsql-docs
On Wed, Jul 24, 2024 at 9:02 AM Zhijie Hou (Fujitsu)
<houzj.fnst@fujitsu.com> wrote:
>
> Thanks for the patch.
>
> Here is one comment:
>
> The second query has a condition 'WHERE slot_name IS NOT NULL', but I
> think it belongs to the first query. Because the slot_name of second query
> is built by CONCAT() which means it should be valid, while the first query's
> subslotname could be NULL if user executed ALTER SUB SET (slot_name = NONE).
>

Thanks for pointing it out. Please find a new patch with this change.

Also corrected the commit message in this patch.

thanks
Shveta

Attachment

pgsql-docs by date:

Previous
From: "Zhijie Hou (Fujitsu)"
Date:
Subject: RE: Correction in doc of failover ready steps
Next
From: PG Doc comments form
Date:
Subject: Incorrect grammar in 15.2