Re: Synchronizing slots from primary to standby - Mailing list pgsql-hackers

From shveta malik
Subject Re: Synchronizing slots from primary to standby
Date
Msg-id CAJpy0uArp5jXFYXpmS1wVpTa+vMsfuR5m2CfN2K-g4BZLuRr+w@mail.gmail.com
Whole thread Raw
In response to Re: Synchronizing slots from primary to standby  (shveta malik <shveta.malik@gmail.com>)
Responses Re: Synchronizing slots from primary to standby
List pgsql-hackers
On Fri, Feb 23, 2024 at 8:35 AM shveta malik <shveta.malik@gmail.com> wrote:
>
> On Thu, Feb 22, 2024 at 4:35 PM Bertrand Drouvot
> <bertranddrouvot.pg@gmail.com> wrote:
> >
> > Suppose that in synchronize_slots() the query would be:
> >
> >     const char *query = "SELECT slot_name, plugin, confirmed_flush_lsn,"
> >         " restart_lsn, catalog_xmin, two_phase, failover,"
> >         " database, conflict_reason"
> >         " FROM pg_catalog.pg_replication_slots"
> >         " WHERE failover and NOT temporary and 1 = 1";
> >
> > Then my comment is to rewrite it to:
> >
> >     const char *query = "SELECT slot_name, plugin, confirmed_flush_lsn,"
> >         " restart_lsn, catalog_xmin, two_phase, failover,"
> >         " database, conflict_reason"
> >         " FROM pg_catalog.pg_replication_slots"
> >         " WHERE failover and NOT temporary and 1 OPERATOR(pg_catalog.=) 1";
> >
> > to ensure the operator "=" is coming from the pg_catalog schema.
> >
>
> Thanks for the details, but slot-sync does not use SPI calls, it uses
> libpqrcv calls. So is this change needed?

Additionally, I would like to have a better understanding of why it's
necessary and whether it addresses any potential security risks.

thanks
Shveta



pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Why is subscription/t/031_column_list.pl failing so much?
Next
From: "Zhijie Hou (Fujitsu)"
Date:
Subject: RE: Synchronizing slots from primary to standby