Re: remove_useless_joins vs. bug #19560 - Mailing list pgsql-hackers

From Ayush Tiwari
Subject Re: remove_useless_joins vs. bug #19560
Date
Msg-id CAJTYsWX=HBovk2FDzA_MbR986rETW93BGR+G+8X=TN1W37oJ4Q@mail.gmail.com
Whole thread
In response to Re: remove_useless_joins vs. bug #19560  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: remove_useless_joins vs. bug #19560
List pgsql-hackers
Hi,

On Sun, 27 Sept 2026 at 22:02, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> I wrote:
> > Concretely, about like this.  This fixes the given reproducer.
> > I've not put thought into what sort of test cases we might want
> > to add.
>
> Now with test cases, a commit message explaining why do it like
> this, and a bit of additional comment-polishing.

Thanks for the patch.

I went through v1.  Grouping the SJE candidates by checkAsUser
looks right to me, including the unset case.  I didn't spot any
issues.  LGTM.

Regards,
Ayush



pgsql-hackers by date:

Previous
From: Xuneng Zhou
Date:
Subject: Re: test: avoid redundant standby catchup in 049_wait_for_lsn
Next
From: Andrew Dunstan
Date:
Subject: Re: [PATCH] Fix TAP tests with recent IPC::Run on Windows