Re: Remove the refint contrib module (for v20) - Mailing list pgsql-hackers

From Ayush Tiwari
Subject Re: Remove the refint contrib module (for v20)
Date
Msg-id CAJTYsWWb6tPKoCcBg-_wHaSYFTMEHgvr9p6xH0y+Rqu-_Qx0Vg@mail.gmail.com
Whole thread
In response to Re: Remove the refint contrib module (for v20)  (Fujii Masao <masao.fujii@gmail.com>)
List pgsql-hackers
Hi,

On Mon, 29 Jun 2026 at 11:53, Fujii Masao <masao.fujii@gmail.com> wrote:
On Sat, Jun 6, 2026 at 4:28 AM Ayush Tiwari <ayushtiwari.slg01@gmail.com> wrote:
>   0002 (test-only) teaches AdjustUpgrade.pm to drop the refint
>   extension and its leftover tables (pkeys, fkeys, fkeys2) from
>   contrib_regression_spi / regression_spi when upgrading from a version
>   that still shipped refint, so cross-version pg_upgrade tests don't
>   fail dump comparison once v20 opens.
>   I followed the existing < 19 btree_gist block style.

In make-based contrib tests with USE_MODULE_DB=1, contrib/spi uses
contrib_regression_autoinc database, since autoinc is the first entry
in MODULES. So, in 0002 patch, shouldn't we also remove
the refint-related objects from contrib_regression_autoinc?

Thanks for the review! 

pgsql-hackers by date:

Previous
From: Ayush Tiwari
Date:
Subject: Re: Remove the refint contrib module (for v20)
Next
From: Corey Huinker
Date:
Subject: Re: use of SPI by postgresImportForeignStatistics