Request a Demo
Home   >   mailing lists

Re: Remove the refint contrib module (for v20) - Mailing list pgsql-hackers

From Ayush Tiwari
Subject Re: Remove the refint contrib module (for v20)
Date
Msg-id CAJTYsWVMX_csjBafWngAqAAXBa=+Uy+rY2Je4jM6CJ11tF38Mw@mail.gmail.com
Whole thread
In response to Re: Remove the refint contrib module (for v20)  (Ayush Tiwari <ayushtiwari.slg01@gmail.com>)
Responses Re: Remove the refint contrib module (for v20)
List pgsql-hackers
Tree view
Hi,

On Mon, 29 Jun 2026 at 11:53, Fujii Masao <masao.fujii@gmail.com> wrote:
On Sat, Jun 6, 2026 at 4:28 AM Ayush Tiwari <ayushtiwari.slg01@gmail.com> wrote:
>   0002 (test-only) teaches AdjustUpgrade.pm to drop the refint
>   extension and its leftover tables (pkeys, fkeys, fkeys2) from
>   contrib_regression_spi / regression_spi when upgrading from a version
>   that still shipped refint, so cross-version pg_upgrade tests don't
>   fail dump comparison once v20 opens.
>   I followed the existing < 19 btree_gist block style.

In make-based contrib tests with USE_MODULE_DB=1, contrib/spi uses
contrib_regression_autoinc database, since autoinc is the first entry
in MODULES. So, in 0002 patch, shouldn't we also remove
the refint-related objects from contrib_regression_autoinc?

Thanks for the review, Fujii-san!

Yes, you are right, I missed removing that in 0002 patch.

v5-0001 is identical to v4-0001.

Adding you suggested changes, in v5.

Regards,
Ayush
Attachment

pgsql-hackers by date:

Previous
From: JoongHyuk Shin
Date:
Subject: Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks
Next
From: Ayush Tiwari
Date:
Subject: Re: Remove the refint contrib module (for v20)