Re: BUG #19484: Segmentation fault triggered by FDW - Mailing list pgsql-bugs

From Ayush Tiwari
Subject Re: BUG #19484: Segmentation fault triggered by FDW
Date
Msg-id CAJTYsWWUfgCZau2fvrZVruXmC+dyOx45L=TyaGzXdywsywDyHQ@mail.gmail.com
Whole thread
In response to Re: BUG #19484: Segmentation fault triggered by FDW  ("Matheus Alcantara" <matheusssilv97@gmail.com>)
Responses Re: BUG #19484: Segmentation fault triggered by FDW
List pgsql-bugs
Hi,

On Tue, 9 Jun 2026 at 20:40, Matheus Alcantara <matheusssilv97@gmail.com> wrote:

I think both patches should be squashed into a single one since they fix
the same underlying issue. I've done this locally and also ran pg_indent
over the result. Attached is the combined patch.

Thanks for this!
 
One minor naming observation: the new fdwPrivLists field in
ModifyTableState doesn't follow the mt_ prefix convention used by the
other re-indexed lists (mt_updateColnosLists, mt_mergeActionLists,
mt_mergeJoinConditions). Should we rename it to mt_fdwPrivLists for
consistency?

I think yes, it makes sense to rename it.

Regards,
Ayush

pgsql-bugs by date:

Previous
From: Fujii Masao
Date:
Subject: Re: BUG #19508: pg_buffercache_pages() crashes the backend with an incompatible caller-supplied record definition
Next
From: PG Bug reporting form
Date:
Subject: BUG #19515: Creating a faulty BRIN operator class can cause the server to crash when used.