Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH v1] eliminate duplicate code in table.c - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: [PATCH v1] eliminate duplicate code in table.c
Date
Msg-id CAJ7c6TPMJP6PtoS3byPZ-s_U4bV-sfbDA0RzzPzM3UQRwctLaA@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH v1] eliminate duplicate code in table.c  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: [PATCH v1] eliminate duplicate code in table.c
List pgsql-hackers
Tree view 
Hi hackers,

> > There are some duplicate code in table.c, add a static inline function
> > to eliminate the duplicates.
> >
>
> Can we name function as validate_object_type, or check_object_type?
>
> Otherwise, the patch looks fine to me. Let's see if others have
> something to say.

LGTM

-- 
Best regards,
Aleksander Alekseev
Attachment

pgsql-hackers by date:

Previous
From: Andrey Lepikhov
Date:
Subject: Re: [PoC] Reducing planning time when tables have many partitions
Next
From: Tomas Vondra
Date:
Subject: Re: Use extended statistics to estimate (Var op Var) clauses