Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH v1] eliminate duplicate code in table.c - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: [PATCH v1] eliminate duplicate code in table.c
Date
Msg-id CAA4eK1+N-bZivTO=2LZH93jxQAwSi+0xvW-Gg1yN_WS2PujwMQ@mail.gmail.com
Whole thread Raw
In response to [PATCH v1] eliminate duplicate code in table.c  (Junwang Zhao <zhjwpku@gmail.com>)
Responses Re: [PATCH v1] eliminate duplicate code in table.c
List pgsql-hackers
Tree view 
On Thu, Jul 21, 2022 at 1:56 PM Junwang Zhao <zhjwpku@gmail.com> wrote:
>
> There are some duplicate code in table.c, add a static inline function
> to eliminate the duplicates.
>

Can we name function as validate_object_type, or check_object_type?

Otherwise, the patch looks fine to me. Let's see if others have
something to say.

-- 
With Regards,
Amit Kapila.

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: standby recovery fails (tablespace related) (tentative patch and discussion)
Next
From: Thomas Munro
Date:
Subject: Re: standby recovery fails (tablespace related) (tentative patch and discussion)