Postgres Pro
Downloads
Home   >   mailing lists

Re: Unit tests for SLRU - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: Unit tests for SLRU
Date
Msg-id CAJ7c6TOzQ8F3Bhe8fSZjYWbjHCP+p7OVwSxVcUR8Q-WZPNqRvg@mail.gmail.com
Whole thread Raw
In response to Re: Unit tests for SLRU  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Unit tests for SLRU
List pgsql-hackers
Tree view 
Hi Michael,

Thanks for the review and also for committing 5ca3645.

> This patch redesigns SimpleLruInit() [...]
> I am not really convinced that this is something that a
> patch aimed at extending testing coverage should redesign, especially
> with a routine as old as that.
> [...] you'd better put this facility in src/test/modules/

Fair enough. PFA the corrected patch v5.

-- 
Best regards,
Aleksander Alekseev
Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Database "contrib_regression" does not exist during testing
Next
From: David Christensen
Date:
Subject: Re: [PATCH] Teach pg_waldump to extract FPIs from the WAL