Request a Demo
Home   >   mailing lists

[PATCH] Remove unused PageIsPredicateLocked() - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject [PATCH] Remove unused PageIsPredicateLocked()
Date
Msg-id CAJ7c6TMCOi-TTfPSWh+wxkOMgqcvoG-FCWPU1iGCfrmA2JOajQ@mail.gmail.com
Whole thread
Responses Re: [PATCH] Remove unused PageIsPredicateLocked()
Re: [PATCH] Remove unused PageIsPredicateLocked()
List pgsql-hackers
Tree view 
Hi,

The proposed patch removes dead code in src/backend/storage/lmgr/predicate.c

If my understanding is correct, PageIsPredicateLocked() was added in
dafaa3efb75 (Feb 2011) but its call was removed in 47ad79122bc (Mar
2011) and we have never used it since. It was mentioned in one recent
discussion [1] but it was pointed out that it can't be used there
either.

If anyone believes that we should keep it alternatively we could cover
it with tests or at least add an Assert() somewhere.

[1]: http://postgr.es/m/CA%2BCOZaBo%2BZpKgMvxcdACUjNtdYipe9Em06iX5KHLTVaTmFibiw%40mail.gmail.com

-- 
Best regards,
Aleksander Alekseev
Attachment

pgsql-hackers by date:

Previous
From: Manuel Reyes Bravo
Date:
Subject: Add a test for index_rebuild_count of REPACK (CONCURRENTLY)
Next
From: Heikki Linnakangas
Date:
Subject: Re: 64-bit MultiXactOffset vs. 9.3->9.4 upgrade, pg_resetwal, "wraparound" msg