Re: [PATCH] Remove unused PageIsPredicateLocked() - Mailing list pgsql-hackers

From Matthias van de Meent
Subject Re: [PATCH] Remove unused PageIsPredicateLocked()
Date
Msg-id CAEze2WgC11g5Ob6s4Vpj+EQsEHRHC5_6m9MZaPLjVg6X9C2Ubg@mail.gmail.com
Whole thread
In response to [PATCH] Remove unused PageIsPredicateLocked()  (Aleksander Alekseev <aleksander@tigerdata.com>)
Responses Re: [PATCH] Remove unused PageIsPredicateLocked()
List pgsql-hackers
On Wed, 16 Sept 2026 at 15:23, Aleksander Alekseev
<aleksander@tigerdata.com> wrote:
>
> Hi,
>
> The proposed patch removes dead code in src/backend/storage/lmgr/predicate.c
>
> If my understanding is correct, PageIsPredicateLocked() was added in
> dafaa3efb75 (Feb 2011) but its call was removed in 47ad79122bc (Mar
> 2011) and we have never used it since. It was mentioned in one recent
> discussion [1] but it was pointed out that it can't be used there
> either.
>
> If anyone believes that we should keep it alternatively we could cover
> it with tests or at least add an Assert() somewhere.

I'm fine with removing it, for reasons including because its signature
promise wasn't ever truly clear.

-Matthias



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: POC: Carefully exposing information without authentication
Next
From: Melanie Plageman
Date:
Subject: Re: WAL_LOG CREATE DATABASE strategy broken for non-standard page layouts