Postgres Pro
Downloads
Home   >   mailing lists

Re: Allow logical replication to copy tables in binary format - Mailing list pgsql-hackers

From Peter Smith
Subject Re: Allow logical replication to copy tables in binary format
Date
Msg-id CAHut+PvbJatcbrCkUaGHe9J0qoTgHuCpe9QGe+eskuyvHeTr5g@mail.gmail.com
Whole thread Raw
In response to Re: Allow logical replication to copy tables in binary format  (Peter Smith <smithpb2250@gmail.com>)
Responses Re: Allow logical replication to copy tables in binary format  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
Tree view 
On Tue, Mar 14, 2023 at 11:06 AM Peter Smith <smithpb2250@gmail.com> wrote:
>
> Here are some review comments for patch v12-0001
>
> ======
> General
>
> 1.
> There is no new test code. Are we sure that there are already
> sufficient TAP tests doing binary testing with/without copy_data and
> covering all the necessary combinations?
>

Oops. Please ignore this comment. Somehow I missed seeing those
032_binary_copy.pl tests earlier.

------
Kind Regards,
Peter Smith.
Fujitsu Australia

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: windows CI failing PMSignalState->PMChildFlags[slot] == PM_CHILD_ASSIGNED
Next
From: Andres Freund
Date:
Subject: Re: ICU 54 and earlier are too dangerous