Hi Vignesh, Here are a few small review comments just for the docs
part of patch 0001:
======
Commit message
1.
In addition to the new command, the following subscription commands have
been enhanced to automatically refresh sequence mappings:
~
Is "mappings" the right word?
======
doc/src/sgml/ref/alter_subscription.sgml
2.
<para>
- When false, the command will not try to refresh table information.
- <literal>REFRESH PUBLICATION</literal> should then be
executed separately.
- The default is <literal>true</literal>.
+ When false, the command will not try to refresh table and sequence
+ information. <literal>REFRESH PUBLICATION</literal> should then be
+ executed separately. The default is <literal>true</literal>.
</para>
I thought false should use markup: <literal>false</literal> (just
like true does)
~~~
3.
+ <para>
+ Previously subscribed sequences are not re-synchronized. To do that,
+ see <link linkend="sql-altersubscription-params-refresh-sequences">
+ <command>ALTER SUBSCRIPTION ... REFRESH SEQUENCES</command></link>.
+ </para>
/To do that, see/To do that, use/
~~~
4.
+ <para>
+ Re-synchronize sequence data with the publisher. Unlike
+ <link linkend="sql-altersubscription-params-refresh-publication">
+ <literal>ALTER SUBSCRIPTION ... REFRESH
PUBLICATION</literal></link> which
+ only synchronizes newly added sequences, <literal>REFRESH
SEQUENCES</literal>
+ will re-synchronize the sequence data for all subscribed sequences. It
+ does not add or remove the missing publication sequences from the
+ subscription.
+ </para>
4a.
IMO the ALTER SUBSCRIPTION command should have <command> markup
instead of <literal>
~
4b.
I wondered if that part "...for all subscribed sequences" should say
"...for all currently subscribed sequences", just for more clarity.
~
4c.
I do not think you need to say "the missing" here; IMO, that just
leads to more questions -- missing from where? How do you remove
something that is missing? etc. The suggestion below removes the
ambiguity.
SUGGESTION:
It does not add or remove sequences from the subscription to match the
publication.
======
Kind Regards,
Peter Smith.
Fujitsu Australia
