Request a Demo
Home   >   mailing lists

Re: Fix lag columns in pg_stat_replication not advancing when replay LSN stalls - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: Fix lag columns in pg_stat_replication not advancing when replay LSN stalls
Date
Msg-id CAHGQGwF3SpdEYC7=Og+9ZvRX09=TDNPh=ChGmFMJGCvckBmWnw@mail.gmail.com
Whole thread Raw
In response to Re: Fix lag columns in pg_stat_replication not advancing when replay LSN stalls  (Xuneng Zhou <xunengzhou@gmail.com>)
List pgsql-hackers
Tree view 
On Tue, Oct 21, 2025 at 11:52 PM Xuneng Zhou <xunengzhou@gmail.com> wrote:
> The patch LGTM.

Thanks for the review!
I've pushed the patch and backpatched it to all supported versions.


> I am wondering whether it is helpful to add some
> comments for this overflowed array

Yes, do you have any specific suggestions?


> and replacing literal zeros with the constant InvalidXLogRecPtr for
> better readability.
>
> /* InvalidXLogRecPtr means no overflow yet */
> if (lag_tracker->overflowed[i].lsn == InvalidXLogRecPtr)

I couldn't find any code like "lag_tracker->overflowed[i].lsn == 0",
so I'm not sure which part should be replaced with InvalidXLogRecPtr.
Could you point me to the exact location?

Regards,

--
Fujii Masao

pgsql-hackers by date:

Previous
From: Peter Smith
Date:
Subject: Re: Logical Replication of sequences
Next
From: jian he
Date:
Subject: Re: Why cannot alter a column's type when it's used by a generated column