Re: [pgadmin-hackers] connection error - Mailing list pgadmin-hackers

From George Gelashvili
Subject Re: [pgadmin-hackers] connection error
Date
Msg-id CAHowoHZo60UKPS8wBXXxU=bXkw2ryj0oUD8QEXZ4wZRQWpGUkQ@mail.gmail.com
Whole thread Raw
In response to [pgadmin-hackers] connection error  (George Gelashvili <ggelashvili@pivotal.io>)
Responses Re: [pgadmin-hackers] connection error
List pgadmin-hackers
aaaand here's a patch

On Thu, Feb 16, 2017 at 11:26 AM, George Gelashvili <ggelashvili@pivotal.io> wrote:
Hi Hackers!

Our tests found a bug with the current version of master, that was introduced by the commit 9ad1316990cf54da665546ad2dff367557b98262.
It is throwing an error when the server starts up and returns an error message of None, and thereby breaking the happy path. There is a function ('create' around line 587) in servers/__init__.py that checks against the attribute 'decode', which the server doesn't have when there isn't an error message.

George & Sarah

Attachment

pgadmin-hackers by date:

Previous
From: George Gelashvili
Date:
Subject: [pgadmin-hackers] connection error
Next
From: Dave Page
Date:
Subject: [pgadmin-hackers] pgAdmin 4 commit: Don't try to decode connection error strings thatare