Try
Home   >   mailing lists

Re: A little cosmetic to convert_VALUES_to_ANY() - Mailing list pgsql-hackers

From Tender Wang
Subject Re: A little cosmetic to convert_VALUES_to_ANY()
Date
Msg-id CAHewXNkAcF0N-Kims+-zd0Y2Mr8UES5vwHjqRUOEtR5G4tnZGw@mail.gmail.com
Whole thread Raw
In response to A little cosmetic to convert_VALUES_to_ANY()  (Tender Wang <tndrwang@gmail.com>)
List pgsql-hackers
Tree view


Tender Wang <tndrwang@gmail.com> 于2025年7月27日周日 15:53写道：
Hi,

While debugging the pull-up sublink codes, I noticed the convert_VALUES_to_ANY().
The function is to convert "where colX in VALUES(xxx)" into SAOP. It firstly scans the values_list to
make sure no volatile function is in this list, then it scans this values_list again to check that it
only includes Const items. 

We can merge the two scans into one. This can reduce the time complexity from 2O(n) to O(n).

Also, add a brace for better/more consistent style in the attached patch.


I have added this to the commitfest in [1]. I hope someone can help me review it.



--
Thanks,
Tender Wang

pgsql-hackers by date:

Previous
From: Andrei Lepikhov
Date:
Subject: Re: SQL function to access to `creating_extension`
Next
From: Alexandra Wang
Date:
Subject: Re: Pathify RHS unique-ification for semijoin planning