Re: Log prefix missing for subscriber log messages received from publisher - Mailing list pgsql-hackers

On Tue, Jul 22, 2025 at 9:49 PM Álvaro Herrera <alvherre@kurilemu.de> wrote:
>
> On 2025-Jul-22, Fujii Masao wrote:
>
> > On Tue, Jul 22, 2025 at 8:47 PM Álvaro Herrera <alvherre@kurilemu.de> wrote:
>
> > > Oh yeah, I should have remembered this -- see commit 213c959a294d.  Feel
> > > free to do away with the whole translation thing ... doesn't seem worth
> > > spending more time on it.
> >
> > Yes! The attached patch removes the translation marker and the
> > gettext_noop() calls I recently added.
>
> LGTM.

Thanks for the review!


> > > We should still remove all gettext_noop() markers in contrib :-)
> >
> > You mean to remove gettext_noop() also from basic_archive.c?
>
> Yes, it's useless and misleading.  Feel free to do it in the same commit ...

I've included that change in the patch and pushed it. Thanks!

Regards,

--
Fujii Masao