Re: CI failure: postgres_fdw_get_connections - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: CI failure: postgres_fdw_get_connections
Date
Msg-id CAHGQGwHr1EbJZE6P0e5kh=HZneOz5nX0m6YLmc_wbvWh0ZuGJg@mail.gmail.com
Whole thread
In response to Re: CI failure: postgres_fdw_get_connections  (Daniel Gustafsson <daniel@yesql.se>)
List pgsql-hackers
On Wed, Jul 15, 2026 at 11:50 PM Daniel Gustafsson <daniel@yesql.se> wrote:
>
> > On 15 Jul 2026, at 16:30, Fujii Masao <masao.fujii@gmail.com> wrote:
> >
> > On Sun, Jun 14, 2026 at 12:18 AM Robert Haas <robertmhaas@gmail.com> wrote:
> >>
> >> On Fri, Jun 12, 2026 at 12:27 AM Fujii Masao <masao.fujii@gmail.com> wrote:
> >>> The attached patch implements this approach.
> >>
> >> This seems reasonable to me on a quick glance. Thanks for working on it!
> >
> > Barring any objections, I will commit this patch and backpatch it to v18,
> > where the affected postgres_fdw_get_connections() test was added.
>
> LGTM.  I'm not sure we need the timeout on pg_terminate_backend?  That's
> however not introduced with this patch, the postgres_fdw tests already use a
> 180s timeout, so keeping it consistent with the rest of the test code seems
> correct.

Thanks for the review! I've pushed the patch.

Regards,

--
Fujii Masao



pgsql-hackers by date:

Previous
From: Jacob Champion
Date:
Subject: Re: PG20 Minimum Dependency Thread
Next
From: Fujii Masao
Date:
Subject: Re: Fix publisher-side sequence permission reporting