Re: CI failure: postgres_fdw_get_connections - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: CI failure: postgres_fdw_get_connections
Date
Msg-id C24EE5A0-1E5A-49F8-B52D-6894D49C27B3@yesql.se
Whole thread
Responses Re: CI failure: postgres_fdw_get_connections
List pgsql-hackers
> On 15 Jul 2026, at 16:30, Fujii Masao <masao.fujii@gmail.com> wrote:
>
> On Sun, Jun 14, 2026 at 12:18 AM Robert Haas <robertmhaas@gmail.com> wrote:
>>
>> On Fri, Jun 12, 2026 at 12:27 AM Fujii Masao <masao.fujii@gmail.com> wrote:
>>> The attached patch implements this approach.
>>
>> This seems reasonable to me on a quick glance. Thanks for working on it!
>
> Barring any objections, I will commit this patch and backpatch it to v18,
> where the affected postgres_fdw_get_connections() test was added.

LGTM.  I'm not sure we need the timeout on pg_terminate_backend?  That's
however not introduced with this patch, the postgres_fdw tests already use a
180s timeout, so keeping it consistent with the rest of the test code seems
correct.

--
Daniel Gustafsson




pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: Grab bag of smaller OpenSSL fixups
Next
From: Tom Lane
Date:
Subject: Re: Fix GROUP BY ALL handling of ORDER BY operator semantics