Try
Home   >   mailing lists

Re: Unexpected Standby Shutdown on sync_replication_slots change - Mailing list pgsql-bugs

From Fujii Masao
Subject Re: Unexpected Standby Shutdown on sync_replication_slots change
Date
Msg-id CAHGQGwHDSah34mkPtN12ZW09K9Ti8KmpCPEpaJgJmo2XrnGC7A@mail.gmail.com
Whole thread Raw
In response to Re: Unexpected Standby Shutdown on sync_replication_slots change  (Hugo DUBOIS <hdubois@scaleway.com>)
Responses Re: Unexpected Standby Shutdown on sync_replication_slots change
List pgsql-bugs
Tree view 
On Fri, Jul 25, 2025 at 9:13 PM Hugo DUBOIS <hdubois@scaleway.com> wrote:
> I'm not sure if there's a particular use case for wal_level and sync_replication_slots not matching on a primary. So,
forme, Option 1 seems correct. 

I also prefer option #1.

However, on second thought, if some users are already running a server
(non-standby) with sync_replication_slots enabled and wal_level != logical
in v17, switching to option #1 could break their setup after a minor
version update. That would be surprising and confusing.

To avoid that, I think we should go with option #2—at least for v17.

Attached is an updated patch implementing option #2.

Regards,

--
Fujii Masao
Attachment

pgsql-bugs by date:

Previous
From: Tom Lane
Date:
Subject: Re: BUG #18999: Equivalent queries processing WHERE IS NULL & WHERE IS NOT NULL produce mutually exclusive results
Next
From: Hugo DUBOIS
Date:
Subject: Re: Unexpected Standby Shutdown on sync_replication_slots change