Re: pgsql: Add archive_mode='always' option. - Mailing list pgsql-committers

From Fujii Masao
Subject Re: pgsql: Add archive_mode='always' option.
Date
Msg-id CAHGQGwGZwq9MtcCccwm+7c3JiW-kaN+YKg01ReKMjU7t-1rw=g@mail.gmail.com
Whole thread Raw
In response to pgsql: Add archive_mode='always' option.  (Heikki Linnakangas <heikki.linnakangas@iki.fi>)
Responses Re: pgsql: Add archive_mode='always' option.  (Heikki Linnakangas <hlinnaka@iki.fi>)
List pgsql-committers
On Sat, May 16, 2015 at 12:55 AM, Heikki Linnakangas
<heikki.linnakangas@iki.fi> wrote:
> Add archive_mode='always' option.
>
> In 'always' mode, the standby independently archives all files it receives
> from the primary.

Thanks a lot!!

-        /* If we have lost the stats collector, try to start a new one */
-        if (PgStatPID == 0 && pmState == PM_RUN)
-            PgStatPID = pgstat_start();

Seems the above code which should exist was removed accidentally.

+     be handled similarly, but the archive_command must test if the file
+     being archived exists already, and if the existing file has identical
+     contents. This requires more care in the archive_command, as it must

Isn't it better to enclose archive_command with <varname> tags?

Regards,

--
Fujii Masao


pgsql-committers by date:

Previous
From: Fujii Masao
Date:
Subject: pgsql: Don't classify REINDEX command as DDL in the pg_audit doc.
Next
From: Heikki Linnakangas
Date:
Subject: pgsql: Put back stats-collector restarting code, removed accidentally.