Re: pgsql: Add archive_mode='always' option. - Mailing list pgsql-committers

On 05/18/2015 09:46 AM, Fujii Masao wrote:
> On Sat, May 16, 2015 at 12:55 AM, Heikki Linnakangas
> <heikki.linnakangas@iki.fi> wrote:
> -        /* If we have lost the stats collector, try to start a new one */
> -        if (PgStatPID == 0 && pmState == PM_RUN)
> -            PgStatPID = pgstat_start();
>
> Seems the above code which should exist was removed accidentally.

Good catch!

> +     be handled similarly, but the archive_command must test if the file
> +     being archived exists already, and if the existing file has identical
> +     contents. This requires more care in the archive_command, as it must
>
> Isn't it better to enclose archive_command with <varname> tags?

Fixed, thanks.

- Heikki