Re: recovery.signal not cleaned up when both signal files are present - Mailing list pgsql-hackers

On Fri, Feb 13, 2026 at 9:55 AM David Steele <david@pgbackrest.org> wrote:
>
> On 2/10/26 11:52, Michael Paquier wrote:
> > On Tue, Feb 10, 2026 at 12:26:36PM +0900, Fujii Masao wrote:
> >> +1 to apply this change only to the master branch. Patch attached.
> >
> > It looks like something we should have a test for, at least..
>
> +1 for a test.

Yeah, so I've added the test as suggested. The updated patch is attached.


> > +    /*
> > +     *
> > +     * If both signal files are present, standby signal file takes precedence.
> > +     * If neither is present then we won't enter archive recovery.
> > +     */
> >
> > This comment's format is incorrect.
>
> Other than the comment the patch looks good overall.

Fixed. Thanks all for the review!

Regards,

--
Fujii Masao