Re: [REVIEW] Re: Compression of full-page-writes - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: [REVIEW] Re: Compression of full-page-writes
Date
Msg-id CAHGQGwEP2c0Baf+jmpnZL+p3x5rUBMTeLXqgwNMdQ0PbdktfTw@mail.gmail.com
Whole thread Raw
In response to Re: [REVIEW] Re: Compression of full-page-writes  (Andres Freund <andres@2ndquadrant.com>)
List pgsql-hackers
On Thu, Mar 5, 2015 at 10:28 PM, Andres Freund <andres@2ndquadrant.com> wrote:
> On 2015-03-05 12:14:04 +0000, Syed, Rahila wrote:
>> Please find attached  a patch. As discussed, flag to denote
>> compression and presence of hole in block image has been added in
>> XLogRecordImageHeader rather than block header.
>
> FWIW, I personally won't commit it with things done that way. I think
> it's going the wrong way, leading to a harder to interpret and less
> flexible format.  I'm not going to further protest if Fujii or Heikki
> commit it this way though.

I'm pretty sure that we can discuss the *better* WAL format even after
committing this patch.

Regards,

-- 
Fujii Masao



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Providing catalog view to pg_hba.conf file - Patch submission
Next
From: Michael Paquier
Date:
Subject: Re: Strange assertion using VACOPT_FREEZE in vacuum.c