There are typos in return type of these functions: 1) timestamptz_pl_interval_at_zone(PG_FUNCTION_ARGS) NOW: PG_RETURN_TIMESTAMP(timestamptz_pl_interval_internal(timestamp, span, attimezone)); SHOULD: PG_RETURN_TIMESTAMPTZ(timestamptz_pl_interval_internal(timestamp, span, attimezone)); 2) Datum timestamptz_mi_interval_at_zone(PG_FUNCTION_ARGS) NOW: PG_RETURN_TIMESTAMP(timestamptz_mi_interval_internal(timestamp, span, attimezone)); SHOULD: PG_RETURN_TIMESTAMPTZ(timestamptz_mi_interval_internal(timestamp, span, attimezone));
You’re right — these are just typos, and they don’t affect correctness since both ultimately call Int64GetDatum(). Still, +1 for fixing them for clarity.
