Re: [COMMITTERS] pgsql: PL/Python: Convert numeric to Decimal - Mailing list pgsql-hackers

From Claudio Freire
Subject Re: [COMMITTERS] pgsql: PL/Python: Convert numeric to Decimal
Date
Msg-id CAGTBQpY-QP2zZzb4Nn1owdhY7dKDCXX9tpHSv1yfBqg11GBDsA@mail.gmail.com
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: PL/Python: Convert numeric to Decimal  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-hackers
On Sun, Jul 7, 2013 at 4:28 PM, Peter Eisentraut <peter_e@gmx.net> wrote:
> On Sun, 2013-07-07 at 02:01 -0300, Claudio Freire wrote:
>> You really want to test more than just the str. The patch contains
>> casts to int and float, which is something existing PLPython code will
>> be doing, so it's good to test it still can be done with decimal.
>
> Let's remember that we are regression testing PL/Python here, not
> Python.  The functionality of PL/Python is to convert a numeric to
> Decimal, and that's what we are testing.  What Python can or cannot do
> with that is not our job to test.

I was just proposing to test behavior likely to be expected by
PL/Python functions, but you probably know better than I.



pgsql-hackers by date:

Previous
From: Markus Wanner
Date:
Subject: Re: Review: extension template
Next
From: Noah Misch
Date:
Subject: Re: [Review] Add SPI_gettypmod() to return a field's typemod from a TupleDesc