Re: [COMMITTERS] pgsql: PL/Python: Convert numeric to Decimal - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [COMMITTERS] pgsql: PL/Python: Convert numeric to Decimal
Date
Msg-id 1373225332.12837.22.camel@vanquo.pezone.net
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: PL/Python: Convert numeric to Decimal  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [COMMITTERS] pgsql: PL/Python: Convert numeric to Decimal
List pgsql-hackers
On Sun, 2013-07-07 at 02:01 -0300, Claudio Freire wrote:
> You really want to test more than just the str. The patch contains
> casts to int and float, which is something existing PLPython code will
> be doing, so it's good to test it still can be done with decimal.

Let's remember that we are regression testing PL/Python here, not
Python.  The functionality of PL/Python is to convert a numeric to
Decimal, and that's what we are testing.  What Python can or cannot do
with that is not our job to test.

> Existing python code will also expect the number to be a float, and
> will try to operate against other floats. That's not going to work
> anymore, that has to go into release notes.

Right, this will be listed in the release notes under upgrade caveats.






pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: [PATCH] Add transforms feature
Next
From: Peter Eisentraut
Date:
Subject: Re: [COMMITTERS] pgsql: PL/Python: Convert numeric to Decimal