Re: 'converts internal representation to "..."' comment is confusing - Mailing list pgsql-hackers

From Steve Chavez
Subject Re: 'converts internal representation to "..."' comment is confusing
Date
Msg-id CAGRrpzbMkhoKJ_4ZWhAL99grMn_WmQKw1qXU9mvUJO6ifveisA@mail.gmail.com
Whole thread Raw
In response to Re: 'converts internal representation to "..."' comment is confusing  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Thanks a lot for the clarification!

The "..." looks enigmatic right now. I think cstring would save newcomers some head-scratching.

Open to suggestions though.

Best regards,
Steve 

On Sun, 14 May 2023 at 22:36, Tom Lane <tgl@sss.pgh.pa.us> wrote:
Steve Chavez <steve@supabase.io> writes:
> I found "..." confusing in some comments, so this patch changes it to
> "cstring". Which seems to be the intention after all.

Those comments are Berkeley-era, making them probably a decade older
than the "cstring" pseudotype (invented in b663f3443).  Perhaps what
you suggest is an improvement, but I'm not sure that appealing to
original intent can make the case.

                        regards, tom lane

pgsql-hackers by date:

Previous
From: "Zhijie Hou (Fujitsu)"
Date:
Subject: RE: walsender performance regression due to logical decoding on standby changes
Next
From: Michael Paquier
Date:
Subject: Re: Bump MIN_WINNT to 0x0600 (Vista) as minimal runtime in 16~