Re: [pgadmin-hackers][patch] Move to Alembic migration system - Mailing list pgadmin-hackers

From Sarah McAlear
Subject Re: [pgadmin-hackers][patch] Move to Alembic migration system
Date
Msg-id CAGRPzo_P+4J2PC4cgYevfTiypF7OFYiELSdaAsCgrzP-y-1S-A@mail.gmail.com
Whole thread Raw
In response to Re: [pgadmin-hackers][patch] Move to Alembic migration system  (Dave Page <dpage@pgadmin.org>)
Responses Re: [pgadmin-hackers][patch] Move to Alembic migration system  (Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io>)
List pgadmin-hackers
Hi!

We realized that this change was causing the tests to fail because the folder for the sqlite databases was not being created. We also updated the files to contain the missing headers.

Thanks!
Joao & Sarah



On Thu, Mar 16, 2017 at 9:31 AM, Dave Page <dpage@pgadmin.org> wrote:
Ashesh, can you review/commit this please? One thing I notice on a
quick look through is that the file headers are missing everywhere.
They should be present in all source files, except where they would
bloat the data transfer from client to server.

On Wed, Mar 15, 2017 at 8:09 PM, Sarah McAlear <smcalear@pivotal.io> wrote:
> Hi Hackers!
>
> It looks like our previous patch messed up some logging. Please use this one
> instead.
>
> Thanks,
> Joao & Sarah
>
>
>
> On Wed, Mar 15, 2017 at 2:46 PM, Sarah McAlear <smcalear@pivotal.io> wrote:
>>
>> Hi Hackers!
>>
>> Here's a patch to move to current db migration system to use Alembic.
>> Instructions to create new migrations are in the README.
>>
>> Thanks!
>> Joao & Sarah
>>
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: [pgadmin-hackers] [pgAdmin4][Patch] To fix the issues in SQLeditor module & Functions node
Next
From: Osahon Oduware
Date:
Subject: [pgadmin-hackers] QGIS Seem To Bypass PostgreSQL/PostGIS User Privileges/Permissions