Postgres Pro
Downloads
Home   >   mailing lists

Re: Speed up JSON escape processing with SIMD plus other optimisations - Mailing list pgsql-hackers

From Melih Mutlu
Subject Re: Speed up JSON escape processing with SIMD plus other optimisations
Date
Msg-id CAGPVpCSr8TJZpsVUWciR7eVWLeEzMr1vw7gvEALUQwB4Upmhjg@mail.gmail.com
Whole thread Raw
In response to Re: Speed up JSON escape processing with SIMD plus other optimisations  (David Rowley <dgrowleyml@gmail.com>)
Responses Re: Speed up JSON escape processing with SIMD plus other optimisations
Re: Speed up JSON escape processing with SIMD plus other optimisations
List pgsql-hackers
Tree view
Hi David,

Thanks for the patch.

In 0001 patch, I see that there are some escape_json() calls with NUL-terminated strings and gets the length by calling strlen(), like below:

- escape_json(&buf, "timestamp");
+ escape_json(&buf, "timestamp", strlen("timestamp"));

 Wouldn't using escape_json_cstring() be better instead? IIUC there isn't much difference between escape_json() and escape_json_cstring(), right? We would avoid strlen() with escape_json_cstring().

Regards,
--
Melih Mutlu
Microsoft

pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: RFC: adding pytest as a supported test framework
Next
From: Andrew Dunstan
Date:
Subject: Re: Speed up JSON escape processing with SIMD plus other optimisations