Request a Demo
Home   >   mailing lists

Re: Proposal: Make cfbot fail on patches not created by "git format-patch" - Mailing list pgsql-hackers

From Jelte Fennema-Nio
Subject Re: Proposal: Make cfbot fail on patches not created by "git format-patch"
Date
Msg-id CAGECzQTgR-rurYDU3Y0D=0ZQPy47bNqmgEkGpLq8VmiQ+WG5UQ@mail.gmail.com
Whole thread Raw
In response to Re: Proposal: Make cfbot fail on patches not created by "git format-patch"  (Jacob Champion <jacob.champion@enterprisedb.com>)
List pgsql-hackers
Tree view 
On Fri, 16 May 2025 at 12:24, Jacob Champion
<jacob.champion@enterprisedb.com> wrote:
>
> On Fri, May 16, 2025 at 12:12 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > That outcome seems entirely horrible to me.  If you want to flag the lack
> > of a commit message somehow, fine, but don't prevent CI from running.
>
> Personally I also prefer nudges to gates.

Okay, reasonable feedback. How about we add a CI job that does a
"quality check". That's much less strong, as all the other tests will
still run, but people would get a failing CI job which tells them that
something is wrong. We could also include a pgindent in that CI job.

pgsql-hackers by date:

Previous
From: Srinath Reddy Sadipiralla
Date:
Subject: Re: Make wal_receiver_timeout configurable per subscription
Next
From: Jelte Fennema-Nio
Date:
Subject: Re: Proposal: Make cfbot fail on patches not created by "git format-patch"