Re: Reorder connection markers in libpq TAP tests - Mailing list pgsql-hackers

From Jelte Fennema
Subject Re: Reorder connection markers in libpq TAP tests
Date
Msg-id CAGECzQTdPqC6AzW40+j+_f6kYpxRoCDFxN41_V3aE8shue_FTw@mail.gmail.com
Whole thread Raw
In response to Re: Reorder connection markers in libpq TAP tests  (Gurjeet Singh <gurjeet@singh.im>)
List pgsql-hackers
LGTM I guess this was an unintended leftover from me reordering the tests a bit in the final stages of getting these patches in.

On Fri, 21 Apr 2023 at 08:38, Gurjeet Singh <gurjeet@singh.im> wrote:
On Thu, Apr 20, 2023 at 11:00 PM Gurjeet Singh <gurjeet@singh.im> wrote:
>
> Commit 7f5b198 introduced TAP tests that use string literals to mark
> the presence of a query in server logs. For no explicable reason, the
> tests with the marker 'connect2' occur before the tests that use
> 'connect1' marker.
>
> The attached patch swaps the connection marker strings so that a
> reader doesn't have to spend extra deciphering why 'connect2' tests
> appear before 'connect1' tests.

Please see attached v2 of the patch. It now includes same fix in
another TAP tests file.


Best regards,
Gurjeet https://Gurje.et
Postgres Contributors Team, http://aws.amazon.com

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Support logical replication of DDLs
Next
From: Alexander Pyhalov
Date:
Subject: buffer refcount leak in foreign batch insert code