Postgres Pro
Downloads
Home   >   mailing lists

Re: Reorder connection markers in libpq TAP tests - Mailing list pgsql-hackers

From Gurjeet Singh
Subject Re: Reorder connection markers in libpq TAP tests
Date
Msg-id CABwTF4USR+RmEx1ef1H=y8x3gJrgSv7+pXubQbsZuyvQ+TBgKw@mail.gmail.com
Whole thread Raw
In response to Reorder connection markers in libpq TAP tests  (Gurjeet Singh <gurjeet@singh.im>)
Responses Re: Reorder connection markers in libpq TAP tests
Re: Reorder connection markers in libpq TAP tests
List pgsql-hackers
Tree view 
On Thu, Apr 20, 2023 at 11:00 PM Gurjeet Singh <gurjeet@singh.im> wrote:
>
> Commit 7f5b198 introduced TAP tests that use string literals to mark
> the presence of a query in server logs. For no explicable reason, the
> tests with the marker 'connect2' occur before the tests that use
> 'connect1' marker.
>
> The attached patch swaps the connection marker strings so that a
> reader doesn't have to spend extra deciphering why 'connect2' tests
> appear before 'connect1' tests.

Please see attached v2 of the patch. It now includes same fix in
another TAP tests file.


Best regards,
Gurjeet https://Gurje.et
Postgres Contributors Team, http://aws.amazon.com
Attachment

pgsql-hackers by date:

Previous
From: Gurjeet Singh
Date:
Subject: Reorder connection markers in libpq TAP tests
Next
From: Jakub Wartak
Date:
Subject: Doc limitation update proposal: include out-of-line OID usage per TOAST-ed columns