Re: [PATCH] Reorganize pqcomm.h a bit - Mailing list pgsql-hackers

From Jelte Fennema-Nio
Subject Re: [PATCH] Reorganize pqcomm.h a bit
Date
Msg-id CAGECzQRpY8rxgkUPtA6Z1YojeT8Yy=Gn3i5rmn0CiV3dvY+YsA@mail.gmail.com
Whole thread Raw
In response to [PATCH] Reorganize pqcomm.h a bit  (Jacob Champion <jacob.champion@enterprisedb.com>)
Responses Re: [PATCH] Reorganize pqcomm.h a bit
List pgsql-hackers
On Fri, Nov 21, 2025, 12:10 Jacob Champion <jacob.champion@enterprisedb.com> wrote:

WDYT?

Overall seems like reasonable restructuring. I think this note feels out of place now though:

* The cancel request code must not match any protocol version number
* we're ever likely to use. This random choice should do.

I think it'd be better to remove that paragraph and maybe extend the section intro to be something like this (feel free to change/ignore as you see fit):

Reserved protocol version numbers. These don't denote an actual protocol version but instead have special semantics. These version numbers will never be used as an actual protocol version. 

Finally, the newline addition at line 71 I don't understand the purpose of. 

pgsql-hackers by date:

Previous
From: Corey Huinker
Date:
Subject: Re: Import Statistics in postgres_fdw before resorting to sampling.
Next
From: Jacob Champion
Date:
Subject: Re: [PATCH] Reorganize pqcomm.h a bit