[PATCH] Reorganize pqcomm.h a bit - Mailing list pgsql-hackers

From Jacob Champion
Subject [PATCH] Reorganize pqcomm.h a bit
Date
Msg-id CAOYmi+=6zg4oXXOQtifrVao_YKiujTDa3u6bxnU08r0FsSig4g@mail.gmail.com
Whole thread Raw
List pgsql-hackers
Hi,

I was reviewing a patchset by Jelte [1] and decided that pqcomm.h has
gotten hard to read/organize.

Attached is a patch that groups the magic PG_PROTOCOL() codes, adds a
comment to a typedef that was orphaned when protocol.h arrived, and
tweaks some whitespace to make the "paragraphs" easier to scan (IMHO).
I did have some misgivings about separating CANCEL_REQUEST_CODE from
its packet struct, but I think it's a net improvement.

WDYT?

--Jacob

[1] https://postgr.es/m/DDPR5BPWH1RJ.1LWAK6QAURVAY@jeltef.nl

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Optimize cardinality estimation when unique keys are fully covered
Next
From: Nico Williams
Date:
Subject: Re: RFC 9266: Channel Bindings for TLS 1.3 support