Re: Make copyObject work in C++ - Mailing list pgsql-hackers

From Jelte Fennema-Nio
Subject Re: Make copyObject work in C++
Date
Msg-id CAGECzQRauVYN19Y-DTiCTCkdNabh+ZqhdaLrUHR6CAU4wm2TFQ@mail.gmail.com
Whole thread
In response to Re: Make copyObject work in C++  (Peter Eisentraut <peter@eisentraut.org>)
Responses Re: Make copyObject work in C++
List pgsql-hackers
On Tue, 31 Mar 2026 at 10:33, Peter Eisentraut <peter@eisentraut.org> wrote:
> Hmm, note that C++ is also used for LLVM/JIT, and by requiring this
> additional feature set we are also imposing new requirements for those
> users.  This has not been fully explored, and I hesitate to add such a
> new requirement at the last moment.

I understand the hesitation, but in practice we already impose those
requirements anyway for non-MSVC compilers because test_cplusplusext
doesn't compile without it. So any compiler that would cause problems
with the new featureset would have already complained about that
before.

> But how about this: We add the feature test that you propose and enable
> the extension based on that.  See attached patch.  This reduces to
> essentially a three-line patch, much simpler than all previous proposals.

If you're still worried, then this sounds like a fine middle-ground
for now. I think we should reconsider adding the automatic /std:c++20
flag for the PG20 dev cycle though.



pgsql-hackers by date:

Previous
From: Chao Li
Date:
Subject: Re: Eliminating SPI / SQL from some RI triggers - take 3
Next
From: Yura Sokolov
Date:
Subject: Re: BM_IO_ERROR flag is lost in TerminateBufferIO due to order of operations in UnlockBufHdrExt