Re: Make copyObject work in C++ - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Make copyObject work in C++
Date
Msg-id 7ddb8894-3939-4846-8d7f-d886b2cb42ab@eisentraut.org
Whole thread Raw
In response to Re: Make copyObject work in C++  ("Jelte Fennema-Nio" <postgres@jeltef.nl>)
Responses Re: Make copyObject work in C++
List pgsql-hackers
On 30.03.26 00:53, Jelte Fennema-Nio wrote:
> On Fri, 27 Mar 2026 at 12:23, Peter Eisentraut <peter@eisentraut.org> 
> wrote:
>> Here is another tidied up patch set for this.  I didn't go quite as far
>> as enabling C++20 by default in meson.build, this would just take more
>> time to work out and test all the different combinations, but I added
>> the flag to the Cirrus CI task, since there we know what compiler we 
>> have.
> 
> I think 0001 and 0002 are good.
> 
> 0003 seems awkward though. Attached is an approach that I think is
> better: It actually checks for the required featureset and adds the
> necessary flags to the compiler.

Hmm, note that C++ is also used for LLVM/JIT, and by requiring this 
additional feature set we are also imposing new requirements for those 
users.  This has not been fully explored, and I hesitate to add such a 
new requirement at the last moment.

But how about this: We add the feature test that you propose and enable 
the extension based on that.  See attached patch.  This reduces to 
essentially a three-line patch, much simpler than all previous proposals.

Attachment

pgsql-hackers by date:

Previous
From: Chao Li
Date:
Subject: Re: Improve pgindent's formatting named fields in struct literals and varidic functions
Next
From: Amit Kapila
Date:
Subject: Re: pg_publication_tables: return NULL attnames when no column list is specified