Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4][Patch]: RM#1184 - Re-docking on the main tabset is broken - Mailing list pgadmin-hackers

From Ashesh Vashi
Subject Re: [pgAdmin4][Patch]: RM#1184 - Re-docking on the main tabset is broken
Date
Msg-id CAG7mmoxVEEXo0t1hx2reEaBkO4OkXkPZ7yJGDUYY6+5jbnpAWA@mail.gmail.com
Whole thread Raw
In response to [pgAdmin4][Patch]: RM#1184 - Re-docking on the main tabset is broken  (Surinder Kumar <surinder.kumar@enterprisedb.com>)
Responses Re: [pgAdmin4][Patch]: RM#1184 - Re-docking on the main tabset is broken  (Surinder Kumar <surinder.kumar@enterprisedb.com>)
List pgadmin-hackers
Tree view

On Sat, Jun 4, 2016 at 3:44 AM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:

Hi,

Please find attached patch for mentioned issue:
Issue: Re-docking on the main tabset is broken
Explanation:
We were missing 'moveable' property. It should be set to false while creating new Browser panel. By default it is true for all registered panels.
I think both browser and dashboard panels were moveable. that is why dockable tab couldn't determine where to re-dock.
 
That has fixed the original issue, but - now it does not allow me to dock any of the panel beneath the 'Browser' panel.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi


I have also added support for moveable property in Panel class.

Please review.

Thanks,
Surinder Kumar



--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Fix typo per Susan.
Next
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Fix styling of Alertify buttons