Postgres Pro
Downloads
Home   >   mailing lists

Re: pgadmin4 l10n issues - Mailing list pgadmin-hackers

From Ashesh Vashi
Subject Re: pgadmin4 l10n issues
Date
Msg-id CAG7mmoxNJHLVOhzWEw+-S5yK7ZXAQeviJJRgUeU09tjj=o=29Q@mail.gmail.com
Whole thread Raw
In response to Re: pgadmin4 l10n issues  (Alexander Lakhin <exclusion@gmail.com>)
Responses Re: pgadmin4 l10n issues  (Alexander Lakhin <exclusion@gmail.com>)
List pgadmin-hackers
Tree view
On Tue, Oct 24, 2017 at 6:08 PM, Alexander Lakhin <exclusion@gmail.com> wrote:
Hi Ashesh,

23.10.2017 08:21, Ashesh Vashi wrote:
Hi Dave/Alexander,

On Thu, Oct 19, 2017 at 6:43 PM, Dave Page <dpage@pgadmin.org> wrote:
Akshay, can you review/commit this, and look into why the remaining strings Alexander notes are not getting translated please?


Did you forget to attach the patch?
 No, I didn't. You can find all my attached files here:
https://www.postgresql.org/message-id/5c7914c8-db5f-cb70-a81e-6e9145039935%40gmail.com
I reviewed your patches.
I have committed the first patch.

About the second patch, I understood the issue.
I prefer another approach, instead of proposed by you.

Problem with the approach, you suggested, is: label for 'miscellaneous' Preference object will be always None.
Instead - read the 'raw_value' from the configuration database.

-- Thanks, Ashesh


Best regards,
------
Alexander Lakhin
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company


Attachment

pgadmin-hackers by date:

Previous
From: Ashesh Vashi
Date:
Subject: pgAdmin 4 commit: Return the translations,and not empty array from the
Next
From: pgAdmin 4 Jenkins
Date:
Subject: Build failed in Jenkins: pgadmin4-master-python27 #360