Re: review: Non-recursive processing of AND/OR lists - Mailing list pgsql-hackers

From Pavel Stehule
Subject Re: review: Non-recursive processing of AND/OR lists
Date
Msg-id CAFj8pRCNuq=Z+pk-O90-emeDan-uv1O8ja0Mv_TebPGfDWOtWg@mail.gmail.com
Whole thread Raw
In response to Re: review: Non-recursive processing of AND/OR lists  (Gurjeet Singh <gurjeet@singh.im>)
Responses Re: review: Non-recursive processing of AND/OR lists  (Gurjeet Singh <gurjeet@singh.im>)
List pgsql-hackers
2013/6/30 Gurjeet Singh <gurjeet@singh.im>:
> On Sun, Jun 30, 2013 at 11:13 AM, Pavel Stehule <pavel.stehule@gmail.com>
> wrote:
>>
>> Hello
>>
>> just one small notices
>>
>> I dislike a name "root_bool_expr", because, there is not a expression,
>> but expression type. Can you use "root_bool_expr_type" instead? It is
>> little bit longer, but more correct. Same not best name is
>> "root_char", maybe "root_bool_op_name"
>>
>> or root_expr_type and root_op_name ???
>
>
> How about naming those 3 variables as follows:
>
> root_expr_kind
> root_expr_name
> root_bool_expr_type

+1

Pavel

>
>
> --
> Gurjeet Singh
>
> http://gurjeet.singh.im/
>
> EnterpriseDB Inc.



pgsql-hackers by date:

Previous
From: Robins Tharakan
Date:
Subject: Re: New regression test time
Next
From: Gurjeet Singh
Date:
Subject: Re: review: Non-recursive processing of AND/OR lists