Re: Question about building an exportable snapshop - Mailing list pgsql-hackers

From Dilip Kumar
Subject Re: Question about building an exportable snapshop
Date
Msg-id CAFiTN-v_sd6EpXpgYyR_5zSwk95=ZgkGyHh6ZRxjDMvJ47C80A@mail.gmail.com
Whole thread Raw
In response to Re: Question about building an exportable snapshop  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
On Wed, Oct 20, 2021 at 5:06 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Tue, Oct 12, 2021 at 6:21 PM Dilip Kumar <dilipbalaut@gmail.com> wrote:
> >
> > While working on the issue [1], I realize that if a subtransaction
> > hasn't done any catalog change then we don't add this in the commit
> > xid list even if we are building a full snapshot [2].
> >
>
> I think this is true only if we have reached SNAPBUILD_CONSISTENT
> state otherwise, we are adding subtransactions in the committed xip
> array by setting 'needs_timetravel' to true. And if we have already
> reached a consistent state before it then we anyway don't need to add
> this. If this is true, do you still see any problem?

Yeah, you are right.

-- 
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Question about building an exportable snapshop
Next
From: Dilip Kumar
Date:
Subject: Re: pgsql: Document XLOG_INCLUDE_XID a little better