Re: REASSIGN OWNED vs. relisshared dep on !relisshared - Mailing list pgsql-hackers

On Wed, Jul 15, 2026 at 2:20 AM Jeff Davis <pgsql@j-davis.com> wrote:
>
> On Mon, 2026-07-13 at 17:04 +0530, Dilip Kumar wrote:
> > PFA a patch for skipping subscriptions belonging to different
> > databases.
>
> I suggest we add a few checks (or asserts) that subdbid==MyDatabaseId
> when reading pg_subscription from anywhere other than the launcher.

Yeah, I've done that

> Also, the REASSIGN OWNED path goes through
> AlterSubscriptionOwner_oid(), whereas both the REASSIGN OWNED and ALTER
> SUBSCRIPTION ... OWNER TO paths go through
> AlterSubscriptionOwner_internal(). It would be more clear to add the
> skipping logic in the former and an assert in the latter.

That makes sense; I've made the change.

> Other than that, LGTM.

Thanks for the review


--
Regards,
Dilip Kumar
Google