Re: abort-time portal cleanup - Mailing list pgsql-hackers

From Dilip Kumar
Subject Re: abort-time portal cleanup
Date
Msg-id CAFiTN-srVcRHNpY+yHr3bpVyOq_p2oq0bOP4Op4f4aiucMQ-Zw@mail.gmail.com
Whole thread Raw
In response to abort-time portal cleanup  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: abort-time portal cleanup
List pgsql-hackers
On Fri, Sep 13, 2019 at 2:13 AM Robert Haas <robertmhaas@gmail.com> wrote:
>
/*
* Otherwise, do nothing to cursors held over from a previous
* transaction.
*/
if (portal->createSubid == InvalidSubTransactionId)
continue;

/*
* Do nothing to auto-held cursors.  This is similar to the case of a
* cursor from a previous transaction, but it could also be that the
* cursor was auto-held in this transaction, so it wants to live on.
*/
if (portal->autoHeld)
continue;

I have one doubt that why do we need the second check. Because before
setting portal->autoHeld to true we always call HoldPortal therein we
set portal->createSubid to InvalidSubTransactionId.  So it seems to me
that the second condition will never reach.  Am I missing something?

-- 
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Victor Wagner
Date:
Subject: Re: PostgreSQL12 and older versions of OpenSSL
Next
From: rmrodriguez@carto.com
Date:
Subject: Re: Optimze usage of immutable functions as relation