Re: patch for RM1460 [pgAdmin4] - Mailing list pgadmin-hackers

From Harshal Dhumal
Subject Re: patch for RM1460 [pgAdmin4]
Date
Msg-id CAFiP3vy-O7R8uCWLqzK90uZ5evHKUFYGvtCveUN=v4UUxXRVEw@mail.gmail.com
Whole thread Raw
In response to Re: patch for RM1460 [pgAdmin4]  (Dave Page <dpage@pgadmin.org>)
Responses Re: patch for RM1460 [pgAdmin4]  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Hi,

PFA attached patch to show save as option always and to show menu save option only when file is changed.

-- 
Harshal Dhumal
Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Thu, Jul 21, 2016 at 6:18 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

Works nicely - committed!

One change I think we should make (please provide a patch when you get
a minute) is to always allow the dropdown menu and Save As to be used,
regardless of whether the file is dirty. Save should only be available
when there are changes of course.

Thanks!

On Wed, Jul 20, 2016 at 1:12 PM, Harshal Dhumal
<harshal.dhumal@enterprisedb.com> wrote:
> Hi,
>
> PFA patch for RM1460
>
> Changes:
> - Opening a file should set the tab name to the filename
> - Editing a file should add a * to the tab name to indicate the file is
> dirty
> - Saving changes to a file should clear the *
> - The Save button should have a drop-down menu, with a Save As option.
>
> --
> Harshal Dhumal
> Software Engineer
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment

pgadmin-hackers by date:

Previous
From: Harshal Dhumal
Date:
Subject: Re: Re: [pgAdmin4][Patch]: RM#1293 - SQL pane is not displaying GRANT queries in Function, Procedure and Trigger node
Next
From: Navnath Gadakh
Date:
Subject: Re: pgAdmin IV : Unittest modular patch