Re: NOT EXIST for PREPARE - Mailing list pgsql-hackers

On Tue, Mar 22, 2016 at 6:04 PM, Yury Zhuravlev <u.zhuravlev@postgrespro.ru> wrote:
>
> I was not sure about the syntax, so this was a prototype. Now, like all completed yet.
>
>>
>> 1) I think this syntax is wrong... Instead the common should be:
>>
>> PREPARE [IF NOT EXISTS] ...
>
> You right. Done.
>
>
>> 2) All of CINE statements we emit a NOTICE skipping message, so you should
>> emit a message like it:
>
> Done.
>
>
>> 3) There are no regression tests
>
> Done.
>>
>> 4) There are no docs
>
> Done.
>

I got an error when build this patch.

$ ./configure --prefix=/home/fabrizio/pgsql --enable-cassert --enable-coverage --enable-tap-tests --enable-depend

...

$ make

...
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -fprofile-arcs -ftest-coverage  -pthread -D_REENTRANT -D_THREAD_SAFE -D_POSIX_PTHREAD_SEMANTICS -DECPG_COMPILE -I../include -I../../../../src/interfaces/ecpg/include -I. -I. -DMAJOR_VERSION=4 -DMINOR_VERSION=12 -DPATCHLEVEL=0 -I../../../../src/include -D_GNU_SOURCE   -c -o preproc.o preproc.c -MMD -MP -MF .deps/preproc.Po
preproc.y: In function ‘base_yyparse’:
preproc.y:8654:15: error: incompatible types when assigning to type ‘struct prep’ from type ‘char *’
  $$ = cat_str(5,mm_strdup("prepare if not exists"),$5,$6,mm_strdup("as"),$8);
               ^
make[4]: *** [preproc.o] Error 1
make[4]: Leaving directory `/data/fabrizio/Dropbox/dev/postgresql/src/interfaces/ecpg/preproc'
make[3]: *** [all-preproc-recurse] Error 2
make[3]: Leaving directory `/data/fabrizio/Dropbox/dev/postgresql/src/interfaces/ecpg'
make[2]: *** [all-ecpg-recurse] Error 2
make[2]: Leaving directory `/data/fabrizio/Dropbox/dev/postgresql/src/interfaces'
make[1]: *** [all-interfaces-recurse] Error 2
make[1]: Leaving directory `/data/fabrizio/Dropbox/dev/postgresql/src'
make: *** [all-src-recurse] Error 2

I also didin't see no psql tab-complete code.

Regards,

--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
>> Timbira: http://www.timbira.com.br
>> Blog: http://fabriziomello.github.io
>> Linkedin: http://br.linkedin.com/in/fabriziomello
>> Twitter: http://twitter.com/fabriziomello
>> Github: http://github.com/fabriziomello