Re: [GSoC] Query History Upgrade - Mailing list pgadmin-hackers

Hi Yosry,

Nice work there. It seems to be working fine except a few suggestions:

1) Fix pep8 issues

2) DOM Statements like below can be avoided and html can be added directly to main template of $el instead of adding extra operations of find, prepend and append. Plus, it makes it difficult to understand what will the DOM look like.

this.$el.find('.query').prepend('<i id="query_source_icon" class="query-history-icon sql-icon-lg"></i>');
$container.append($toggleEl).append(self.$el);

3) Change the below to use class d-none with toggleClass('d-none') for consistency across.

    this.$el.find('.pgadmin-query-history-entry').each(function() {
      $(this).toggle();
    });

4) I may be wrong, but I'm seeing the flash icon for view/edit data queries and view table icon for query tool queries. Looks like they are swapped.